I agree. Most SHTF situations would not be so bad that gold and silver lost value and even if they did they would probably be the first thing to regain value during recovery. I recommend keeping some of both on hand, just not depending on it to solve all problems.During currency collapses and hyperinflation in the past, gold and silver have held their value.
Precious metals are not a solution for a hardcore SHTF situation, you are right. Saying they are worthless is wrong. They always have had worth, they always will.
There is no single product or item to own, besides an off-grid emp proof produce and livestock farm that has fallout shelters and is fully self sufficient, that IS a good solution to a hardcore SHTF situation.
If you are making good money, like oh lets say $80K+/year, it might make sense to keep a a couple thousand in cash and a couple thousand in bullion in a fireproof safe. How are you going to pay for rent/mortgage when hyperinflation hits and the bank wants the mortgage money? It does have reason and history behind it.
If you are making $30-40k/year, It would make more sense to have some cash and use that bullion money for food/water.
Its just not THE one thing you should do to prepare for bad time. Its something that makes sense for some people.
I actually think the most likely SHTF scenario would be an EMP. If that were to happen, the value of gold and silver would be exactly zero. Maybe not immediately, but it wouldn't take long for folks to figure out you can't eat gold.